Getting list selectors to work properly with ripple on Lollipop, removed unused Holo drawables, fixing action bar theme, etc.

app/src/main/java/org/transdroid/core/gui/TorrentsActivity.java

@@ -207,7 +207,7 @@ public class TorrentsActivity extends ActionBarActivity implements ActionBar.OnN
 		actionBar.setDisplayShowTitleEnabled(false);
 		actionBar.setDisplayShowCustomEnabled(true);
 		actionBar.setCustomView(serverStatusView);
-		navigationSpinnerAdapter = FilterListDropDownAdapter_.getInstance_(this);
+		navigationSpinnerAdapter = FilterListDropDownAdapter_.getInstance_(getSupportActionBar().getThemedContext());
 		// Servers are always added to the action bar spinner
 		navigationSpinnerAdapter.updateServers(applicationSettings.getAllServerSettings());
 

app/src/main/java/org/transdroid/core/gui/lists/TorrentProgressBar.java

@@ -82,12 +82,12 @@ public class TorrentProgressBar extends View {
 	}
 
 	private void initPaints() {
-		notdonePaint.setColor(0xFFEEEEEE);		// Light grey
+		notdonePaint.setColor(getResources().getColor(R.color.torrent_background));
-		inactiveDonePaint.setColor(0xFFA759D4);	// Purple
+		inactiveDonePaint.setColor(getResources().getColor(R.color.torrent_paused));
-		inactivePaint.setColor(0xFF9E9E9E);		// Grey
+		inactivePaint.setColor(getResources().getColor(R.color.torrent_other));
-		progressPaint.setColor(0xFF42A8FA);		// Blue
+		progressPaint.setColor(getResources().getColor(R.color.torrent_downloading));
-		donePaint.setColor(0xFF8ACC12);			// Green
+		donePaint.setColor(getResources().getColor(R.color.torrent_seeding));
-		errorPaint.setColor(0xFFDE3939);		// Red
+		errorPaint.setColor(getResources().getColor(R.color.torrent_error));
 	}
 
 	@Override

app/src/main/java/org/transdroid/core/gui/search/SearchActivity.java

@@ -17,15 +17,14 @@
 package org.transdroid.core.gui.search;
 
 import android.annotation.TargetApi;
-import android.app.ActionBar;
-import android.app.ActionBar.OnNavigationListener;
-import android.app.Activity;
 import android.app.SearchManager;
 import android.content.Intent;
 import android.net.Uri;
 import android.os.Build;
 import android.os.Bundle;
 import android.provider.SearchRecentSuggestions;
+import android.support.v7.app.ActionBar;
+import android.support.v7.app.ActionBarActivity;
 import android.view.Menu;
 import android.view.MenuItem;
 import android.view.View;
@@ -60,7 +59,7 @@ import java.util.List;
  */
 @EActivity(resName = "activity_search")
 @OptionsMenu(resName = "activity_search")
-public class SearchActivity extends Activity implements OnNavigationListener {
+public class SearchActivity extends ActionBarActivity implements ActionBar.OnNavigationListener {
 
 	@FragmentById(resName = "searchresults_fragment")
 	protected SearchResultsFragment fragmentResults;
@@ -97,7 +96,7 @@ public class SearchActivity extends Activity implements OnNavigationListener {
 		// Set the theme according to the user preference
 		if (SystemSettings_.getInstance_(this).useDarkTheme()) {
 			setTheme(R.style.TransdroidTheme_Dark);
-			getActionBar().setIcon(R.drawable.ic_activity_torrents);
+			getSupportActionBar().setIcon(R.drawable.ic_activity_torrents);
 		}
 		super.onCreate(savedInstanceState);
 	}
@@ -127,7 +126,7 @@ public class SearchActivity extends Activity implements OnNavigationListener {
 		}
 
 		// Allow site selection via list (on large screens) or action bar spinner
-		getActionBar().setDisplayHomeAsUpEnabled(true);
+		getSupportActionBar().setDisplayHomeAsUpEnabled(true);
 		if (searchsitesList != null) {
 			// The current layout has a dedicated list view to select the search site
 			SearchSitesAdapter searchSitesAdapter = SearchSitesAdapter_.getInstance_(this);
@@ -140,12 +139,12 @@ public class SearchActivity extends Activity implements OnNavigationListener {
 			}
 		} else {
 			// Use the action bar spinner to select sites
-			getActionBar().setNavigationMode(ActionBar.NAVIGATION_MODE_LIST);
+			getSupportActionBar().setNavigationMode(ActionBar.NAVIGATION_MODE_LIST);
-			getActionBar().setDisplayShowTitleEnabled(false);
+			getSupportActionBar().setDisplayShowTitleEnabled(false);
-			getActionBar().setListNavigationCallbacks(new SearchSettingsDropDownAdapter(this, searchSites), this);
+			getSupportActionBar().setListNavigationCallbacks(new SearchSettingsDropDownAdapter(this, searchSites), this);
 			// Select the last used site; this also starts the search!
 			if (lastUsedPosition >= 0) {
-				getActionBar().setSelectedNavigationItem(lastUsedPosition);
+				getSupportActionBar().setSelectedNavigationItem(lastUsedPosition);
 			}
 		}
 
@@ -274,7 +273,7 @@ public class SearchActivity extends Activity implements OnNavigationListener {
 			// Save the search site currently used to search for future usage
 			applicationSettings.setLastUsedSearchSite(lastUsedSite);
 			// Update the activity title (only shown on large devices)
-			getActionBar().setTitle(NavigationHelper.buildCondensedFontString(
+			getSupportActionBar().setTitle(NavigationHelper.buildCondensedFontString(
 							getString(R.string.search_queryonsite, lastUsedQuery, lastUsedSite.getName())));
 			// Ask the results fragment to start a search for the specified query
 			fragmentResults.startSearch(lastUsedQuery, (SearchSite) lastUsedSite);

app/src/main/java/org/transdroid/core/gui/settings/OverflowPreference.java

@@ -3,6 +3,8 @@ package org.transdroid.core.gui.settings;
 import org.transdroid.R;
 
 import android.content.Context;
+import android.content.res.TypedArray;
+import android.os.Build;
 import android.preference.Preference;
 import android.util.AttributeSet;
 import android.view.View;
@@ -48,7 +50,9 @@ public class OverflowPreference extends Preference {
 	    int top = layout.getPaddingTop();
 	    int right = layout.getPaddingRight();
 	    int left = layout.getPaddingLeft();
-	    layout.setBackgroundResource(R.drawable.selectable_background_holo_light);
+		TypedArray ta = getContext().obtainStyledAttributes(new int[] { android.R.attr.selectableItemBackground });
+	    layout.setBackgroundDrawable(ta.getDrawable(0));
+		ta.recycle();
 	    layout.setPadding(left, top, right, bottom);
 		layout.setOnClickListener(new OnClickListener() {
 			@Override