You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
99 lines
3.4 KiB
99 lines
3.4 KiB
/** |
|
* @fileoverview Rule to flag when using constructor without parentheses |
|
* @author Ilya Volodin |
|
*/ |
|
|
|
"use strict"; |
|
|
|
//------------------------------------------------------------------------------ |
|
// Requirements |
|
//------------------------------------------------------------------------------ |
|
|
|
const astUtils = require("./utils/ast-utils"); |
|
|
|
//------------------------------------------------------------------------------ |
|
// Helpers |
|
//------------------------------------------------------------------------------ |
|
|
|
//------------------------------------------------------------------------------ |
|
// Rule Definition |
|
//------------------------------------------------------------------------------ |
|
|
|
module.exports = { |
|
meta: { |
|
type: "layout", |
|
|
|
docs: { |
|
description: "enforce or disallow parentheses when invoking a constructor with no arguments", |
|
category: "Stylistic Issues", |
|
recommended: false, |
|
url: "https://eslint.org/docs/rules/new-parens" |
|
}, |
|
|
|
fixable: "code", |
|
schema: { |
|
anyOf: [ |
|
{ |
|
type: "array", |
|
items: [ |
|
{ |
|
enum: ["always", "never"] |
|
} |
|
], |
|
minItems: 0, |
|
maxItems: 1 |
|
} |
|
] |
|
}, |
|
messages: { |
|
missing: "Missing '()' invoking a constructor.", |
|
unnecessary: "Unnecessary '()' invoking a constructor with no arguments." |
|
} |
|
}, |
|
|
|
create(context) { |
|
const options = context.options; |
|
const always = options[0] !== "never"; // Default is always |
|
|
|
const sourceCode = context.getSourceCode(); |
|
|
|
return { |
|
NewExpression(node) { |
|
if (node.arguments.length !== 0) { |
|
return; // if there are arguments, there have to be parens |
|
} |
|
|
|
const lastToken = sourceCode.getLastToken(node); |
|
const hasLastParen = lastToken && astUtils.isClosingParenToken(lastToken); |
|
|
|
// `hasParens` is true only if the new expression ends with its own parens, e.g., new new foo() does not end with its own parens |
|
const hasParens = hasLastParen && |
|
astUtils.isOpeningParenToken(sourceCode.getTokenBefore(lastToken)) && |
|
node.callee.range[1] < node.range[1]; |
|
|
|
if (always) { |
|
if (!hasParens) { |
|
context.report({ |
|
node, |
|
messageId: "missing", |
|
fix: fixer => fixer.insertTextAfter(node, "()") |
|
}); |
|
} |
|
} else { |
|
if (hasParens) { |
|
context.report({ |
|
node, |
|
messageId: "unnecessary", |
|
fix: fixer => [ |
|
fixer.remove(sourceCode.getTokenBefore(lastToken)), |
|
fixer.remove(lastToken), |
|
fixer.insertTextBefore(node, "("), |
|
fixer.insertTextAfter(node, ")") |
|
] |
|
}); |
|
} |
|
} |
|
} |
|
}; |
|
} |
|
};
|
|
|