You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
58 lines
1.7 KiB
58 lines
1.7 KiB
3 years ago
|
/**
|
||
|
|
* @fileoverview Reports useless `catch` clauses that just rethrow their error.
|
||
|
|
* @author Teddy Katz
|
||
|
|
*/
|
||
|
|
|
||
|
|
"use strict";
|
||
|
|
|
||
|
|
//------------------------------------------------------------------------------
|
||
|
|
// Rule Definition
|
||
|
|
//------------------------------------------------------------------------------
|
||
|
|
|
||
|
|
module.exports = {
|
||
|
|
meta: {
|
||
|
|
type: "suggestion",
|
||
|
|
|
||
|
|
docs: {
|
||
|
|
description: "disallow unnecessary `catch` clauses",
|
||
|
|
category: "Best Practices",
|
||
|
|
recommended: true,
|
||
|
|
url: "https://eslint.org/docs/rules/no-useless-catch"
|
||
|
|
},
|
||
|
|
|
||
|
|
schema: [],
|
||
|
|
|
||
|
|
messages: {
|
||
|
|
unnecessaryCatchClause: "Unnecessary catch clause.",
|
||
|
|
unnecessaryCatch: "Unnecessary try/catch wrapper."
|
||
|
|
}
|
||
|
|
},
|
||
|
|
|
||
|
|
create(context) {
|
||
|
|
return {
|
||
|
|
CatchClause(node) {
|
||
|
|
if (
|
||
|
|
node.param &&
|
||
|
|
node.param.type === "Identifier" &&
|
||
|
|
node.body.body.length &&
|
||
|
|
node.body.body[0].type === "ThrowStatement" &&
|
||
|
|
node.body.body[0].argument.type === "Identifier" &&
|
||
|
|
node.body.body[0].argument.name === node.param.name
|
||
|
|
) {
|
||
|
|
if (node.parent.finalizer) {
|
||
|
|
context.report({
|
||
|
|
node,
|
||
|
|
messageId: "unnecessaryCatchClause"
|
||
|
|
});
|
||
|
|
} else {
|
||
|
|
context.report({
|
||
|
|
node: node.parent,
|
||
|
|
messageId: "unnecessaryCatch"
|
||
|
|
});
|
||
|
|
}
|
||
|
|
}
|
||
|
|
}
|
||
|
|
};
|
||
|
|
}
|
||
|
|
};
|