You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
70 lines
2.2 KiB
70 lines
2.2 KiB
3 years ago
|
/**
|
||
|
|
* @author Toru Nagashima
|
||
|
|
* @copyright 2017 Toru Nagashima. All rights reserved.
|
||
|
|
* See LICENSE file in root directory for full license.
|
||
|
|
*/
|
||
|
|
'use strict'
|
||
|
|
|
||
|
|
// ------------------------------------------------------------------------------
|
||
|
|
// Requirements
|
||
|
|
// ------------------------------------------------------------------------------
|
||
|
|
|
||
|
|
const utils = require('../utils')
|
||
|
|
|
||
|
|
// ------------------------------------------------------------------------------
|
||
|
|
// Helpers
|
||
|
|
// ------------------------------------------------------------------------------
|
||
|
|
|
||
|
|
/**
|
||
|
|
* Check whether the given `v-if` node is using the variable which is defined by the `v-for` directive.
|
||
|
|
* @param {VDirective} vIf The `v-if` attribute node to check.
|
||
|
|
* @returns {boolean} `true` if the `v-if` is using the variable which is defined by the `v-for` directive.
|
||
|
|
*/
|
||
|
|
function isUsingIterationVar(vIf) {
|
||
|
|
const element = vIf.parent.parent
|
||
|
|
return Boolean(
|
||
|
|
vIf.value &&
|
||
|
|
vIf.value.references.some((reference) =>
|
||
|
|
element.variables.some(
|
||
|
|
(variable) =>
|
||
|
|
variable.id.name === reference.id.name && variable.kind === 'v-for'
|
||
|
|
)
|
||
|
|
)
|
||
|
|
)
|
||
|
|
}
|
||
|
|
|
||
|
|
// ------------------------------------------------------------------------------
|
||
|
|
// Rule Definition
|
||
|
|
// ------------------------------------------------------------------------------
|
||
|
|
|
||
|
|
module.exports = {
|
||
|
|
meta: {
|
||
|
|
type: 'suggestion',
|
||
|
|
docs: {
|
||
|
|
description: 'disallow confusing `v-for` and `v-if` on the same element',
|
||
|
|
categories: ['vue3-recommended', 'recommended'],
|
||
|
|
url: 'https://eslint.vuejs.org/rules/no-confusing-v-for-v-if.html'
|
||
|
|
},
|
||
|
|
deprecated: true,
|
||
|
|
replacedBy: ['no-use-v-if-with-v-for'],
|
||
|
|
fixable: null,
|
||
|
|
schema: []
|
||
|
|
},
|
||
|
|
/** @param {RuleContext} context */
|
||
|
|
create(context) {
|
||
|
|
return utils.defineTemplateBodyVisitor(context, {
|
||
|
|
"VAttribute[directive=true][key.name.name='if']"(node) {
|
||
|
|
const element = node.parent.parent
|
||
|
|
|
||
|
|
if (utils.hasDirective(element, 'for') && !isUsingIterationVar(node)) {
|
||
|
|
context.report({
|
||
|
|
node,
|
||
|
|
loc: node.loc,
|
||
|
|
message: "This 'v-if' should be moved to the wrapper element."
|
||
|
|
})
|
||
|
|
}
|
||
|
|
}
|
||
|
|
})
|
||
|
|
}
|
||
|
|
}
|